mrkubax10/industrialtest
1
2
Fork 2
Code Issues 3 Pull Requests Packages Projects Releases 6 Wiki Activity

Sabers don't do full damage in MCL #22

New Issue
Open
opened 2024-05-11 00:11:59 +02:00 by HandfulOfFrogs · 6 comments
HandfulOfFrogs commented 2024-05-11 00:11:59 +02:00
Contributor
Copy Link

When I hit something with an electric saber (it's powered on), only 1 point of damage is dealt to the entity

When I hit something with an electric saber (it's powered on), only 1 point of damage is dealt to the entity
mrkubax10 commented 2024-05-11 10:22:59 +02:00
Owner
Copy Link

That's the limitation of Minetest engine itself because you cannot register callback that will be called after hitting entity, only players. Since all electric tools use callbacks to check if they are charged it's not possible to fix it right now.

That's the limitation of Minetest engine itself because you cannot register callback that will be called after hitting entity, only players. Since all electric tools use callbacks to check if they are charged it's not possible to fix it right now.
mrkubax10 added the
wontfix
 label 2024-05-11 10:23:06 +02:00
HandfulOfFrogs commented 2024-05-11 10:49:03 +02:00
Author
Contributor
Copy Link

Someone has been able to do a similar thing by overriding on_punch for all living entities. https://forum.minetest.net/viewtopic.php?t=11229

This is a hack but maybe it's what we need?

Someone has been able to do a similar thing by overriding `on_punch` for all living entities. https://forum.minetest.net/viewtopic.php?t=11229 This is a hack but maybe it's what we need?
HandfulOfFrogs commented 2024-05-11 10:50:22 +02:00
Author
Contributor
Copy Link

I'm not sure where the issue is considering in UI it shows that damage of the saber is 9, but it still deals only inactive damage

I'm not sure where the issue is considering in UI it shows that damage of the saber is 9, but it still deals only inactive damage
mrkubax10 commented 2024-05-11 11:17:18 +02:00
Owner
Copy Link

The way how electric tools are implemented is that there are 2 variants registered for each tool: inactive and active. Just before usage in appropriate callback it's determined if tool can switch to active mode (if there is enough power stored) and it's replaced with active variant. Same in opposite way if tool doesn't have enough power it's replaced with inactive variant. That's why electric tools are dependent on callbacks.

The way how electric tools are implemented is that there are 2 variants registered for each tool: inactive and active. Just before usage in appropriate callback it's determined if tool can switch to active mode (if there is enough power stored) and it's replaced with active variant. Same in opposite way if tool doesn't have enough power it's replaced with inactive variant. That's why electric tools are dependent on callbacks.
mrkubax10 commented 2024-05-11 11:19:24 +02:00
Owner
Copy Link

This is a hack but maybe it's what we need?

Seems like a reasonable solution.

> This is a hack but maybe it's what we need? Seems like a reasonable solution.
HandfulOfFrogs commented 2024-05-11 12:30:17 +02:00
Author
Contributor
Copy Link

it's replaced with active variant. Same in opposite way if tool doesn't have enough power it's replaced with inactive variant.

What I'm saying is that, I assume, the saber is already in its "active" variant after breaking a leaf block (GUI shows 9 damage) but it still deals 1

>it's replaced with active variant. Same in opposite way if tool doesn't have enough power it's replaced with inactive variant. What I'm saying is that, I assume, the saber is already in its "active" variant after breaking a leaf block (GUI shows 9 damage) but it still deals 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
compat-mode:mineclone2

   
compat-mode:minetest_game

   
crash

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
compat-mode:mineclone2
compat-mode:minetest_game
crash
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrkubax10/industrialtest#22
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?