some fixes #8

usrib · 2024-03-29T15:09:14+01:00

usrib commented

2024-03-29 15:09:14 +01:00

First-time contributor

fix S() function calls
MineClonia mcl_armor fix
MineClonia bonemeal fast fix
locales template

fixes #5

- fix `S()` function calls - MineClonia mcl_armor fix - MineClonia bonemeal fast fix - locales template fixes #5

usrib added 4 commits 2024-03-29 15:09:18 +01:00

correct use of S() func 1e28f1c565

locale template c2ad845ca2

Merge branch 'master' of https://git.cubesoftware.xyz/mrkubax10/industrialtest into s-func 64f1ab4275

Merge branch 'master' into mcla-support b733d72cda

mrkubax10 commented

2024-03-29 18:02:35 +01:00

Thanks for your contribution! Could you clean up commit history to remove merge commits? This way I can just do merge and not squash and merge to preserve original commits.

usrib force-pushed mcla-support from b733d72cda to c2ad845ca2

2024-03-31 23:46:26 +02:00

Compare

usrib commented

2024-03-31 23:47:15 +02:00

First-time contributor

sorry I dont know how do this

mrkubax10 commented

2024-04-01 16:35:47 +02:00

I can do it for you then.

mrkubax10 reviewed 2024-04-02 11:29:03 +02:00

api.lua

						
				@ -648,3 +648,3 @@

				industrialtest.api.registerResourceDust=function(name,displayName,resources,color,registerMaceratorRecipe)

					minetest.register_craftitem("industrialtest:"..name.."_dust",{

						description=S(displayName.." Dust"),

						description=S("@1 Dust", displayName),

mrkubax10 commented

2024-04-02 11:29:03 +02:00

The reason why I wrote these function calls this way is because in some languages (like Polish) words have to be translated together, otherwise sometimes you will get incorrect results. For example "proszek" means "dust" and "miedź" is "copper", translating these words separately and concatenating into single string would result in "Miedź proszek" which is not right at all. Correct translation would be "Miedziany proszek".

usrib commented

2024-04-07 15:45:05 +02:00

First-time contributor

The reason why I wrote these function calls this way is because in some languages (like Polish) words have to be translated together, otherwise sometimes you will get incorrect results. For example "proszek" means "dust" and "miedź" is "copper", translating these words separately and concatenating into single string would result in "Miedź proszek" which is not right at all. Correct translation would be "Miedziany proszek".

I understand, but using the correct method could benefit the translators, in addition, this allows the @1 or @2 to be ordered correctly for each language in the translation templates, for example in Polish you can alternate "@2 something @1 " and in Spanish we order it "@1 something @2" in their respective translation templates. Or even skip "@1" and type the word directly.

Consider using the correct S() function calls, I think it is beneficial.

> The reason why I wrote these function calls this way is because in some languages (like Polish) words have to be translated together, otherwise sometimes you will get incorrect results. For example "proszek" means "dust" and "miedź" is "copper", translating these words separately and concatenating into single string would result in "Miedź proszek" which is not right at all. Correct translation would be "Miedziany proszek". I understand, but using the correct method could benefit the translators, in addition, this allows the @1 or @2 to be ordered correctly for each language in the translation templates, for example in Polish you can alternate "@2 something @1 " and in Spanish we order it "@1 something @2" in their respective translation templates. Or even skip "@1" and type the word directly. Consider using the correct S() function calls, I think it is beneficial.

mrkubax10 commented

2024-04-07 20:53:59 +02:00

Since the resulting lookup string passed to S contains both words you can translate it however you want.

Since the resulting lookup string passed to `S` contains both words you can translate it however you want.